From 950720b06356e62fe1fe9e574bfada13b44969d1 Mon Sep 17 00:00:00 2001
From: Thomas Voss <mail@thomasvoss.com>
Date: Thu, 9 May 2024 14:22:24 +0200
Subject: Add TODOs
---
lib/unicode/prop/uprop_get_lc.c | 1 +
lib/unicode/prop/uprop_get_nfkc_cf.c | 1 +
lib/unicode/prop/uprop_get_nfkc_scf.c | 1 +
lib/unicode/prop/uprop_get_tc.c | 1 +
lib/unicode/prop/uprop_get_uc.c | 1 +
5 files changed, 5 insertions(+)
(limited to 'lib')
diff --git a/lib/unicode/prop/uprop_get_lc.c b/lib/unicode/prop/uprop_get_lc.c
index 752ed71..faf26c3 100644
--- a/lib/unicode/prop/uprop_get_lc.c
+++ b/lib/unicode/prop/uprop_get_lc.c
@@ -47,6 +47,7 @@ uprop_get_lc(rune ch, struct lcctx ctx)
return M(U'ı');
}
+ /* TODO: This returns a pointer to a stack-allocated array; fix this! */
ch = uprop_get_slc(ch);
return M(ch);
}
diff --git a/lib/unicode/prop/uprop_get_nfkc_cf.c b/lib/unicode/prop/uprop_get_nfkc_cf.c
index 9b19df3..1fe282e 100644
--- a/lib/unicode/prop/uprop_get_nfkc_cf.c
+++ b/lib/unicode/prop/uprop_get_nfkc_cf.c
@@ -17699,5 +17699,6 @@ struct rview
uprop_get_nfkc_cf(rune ch)
{
struct rview rv = stage2[stage1[ch / 256]][ch % 256];
+ /* TODO: This returns a pointer to a stack-allocated array; fix this! */
return rv.len == 1 && rv.p[0] == SENTINAL ? M(ch) : rv;
}
diff --git a/lib/unicode/prop/uprop_get_nfkc_scf.c b/lib/unicode/prop/uprop_get_nfkc_scf.c
index abafff6..1738874 100644
--- a/lib/unicode/prop/uprop_get_nfkc_scf.c
+++ b/lib/unicode/prop/uprop_get_nfkc_scf.c
@@ -17699,5 +17699,6 @@ struct rview
uprop_get_nfkc_scf(rune ch)
{
struct rview rv = stage2[stage1[ch / 256]][ch % 256];
+ /* TODO: This returns a pointer to a stack-allocated array; fix this! */
return rv.len == 1 && rv.p[0] == SENTINAL ? M(ch) : rv;
}
diff --git a/lib/unicode/prop/uprop_get_tc.c b/lib/unicode/prop/uprop_get_tc.c
index e2d8212..cececd8 100644
--- a/lib/unicode/prop/uprop_get_tc.c
+++ b/lib/unicode/prop/uprop_get_tc.c
@@ -1466,6 +1466,7 @@ uprop_get_tc(rune ch, struct tcctx ctx)
struct rview rv = stage2[stage1[ch / 64]][ch % 64];
if (rv.p != nullptr)
return rv;
+ /* TODO: This returns a pointer to a stack-allocated array; fix this! */
ch = uprop_get_stc(ch);
return M(ch);
}
diff --git a/lib/unicode/prop/uprop_get_uc.c b/lib/unicode/prop/uprop_get_uc.c
index 7e39181..698c61c 100644
--- a/lib/unicode/prop/uprop_get_uc.c
+++ b/lib/unicode/prop/uprop_get_uc.c
@@ -1147,6 +1147,7 @@ uprop_get_uc(rune ch, struct ucctx ctx)
struct rview rv = stage2[stage1[ch / 128]][ch % 128];
if (rv.p != nullptr)
return rv;
+ /* TODO: This returns a pointer to a stack-allocated array; fix this! */
ch = uprop_get_suc(ch);
return M(ch);
}
--
cgit v1.2.3